Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ai): add ability to use float pricePerUnit #3248

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

rickstaa
Copy link
Member

What does this pull request do? Explain your changes. (required)

This commit gives orchestrators the ability to set the pricePerUnit as a
float so that they do not have to rely on the pricePerPixel field.

Specific updates (required)

  • For AI the pricePerPixel field now can take a float.

How did you test each of these updates (required)

Does this pull request close any open issues?

It will simplify the docs.

Checklist:

  • Read the contribution guide
  • make runs successfully
  • All tests in ./test.sh pass
  • README and other documentation updated -> will be done after this is merged.
  • Pending changelog updated

This commit gives orchestrators the ability to set the pricePerUnit as a
float so that they do not have to rely on the pricePerPixel field.
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.74499%. Comparing base (b87c7c3) to head (8a441f8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/livepeer/starter/starter.go 0.00000% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3248         +/-   ##
===================================================
- Coverage   34.74775%   34.74499%   -0.00276%     
===================================================
  Files            136         136                 
  Lines          36175       36175                 
===================================================
- Hits           12570       12569          -1     
- Misses         22893       22894          +1     
  Partials         712         712                 
Files with missing lines Coverage Δ
cmd/livepeer/starter/starter.go 7.68738% <0.00000%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b87c7c3...8a441f8. Read the comment docs.

Files with missing lines Coverage Δ
cmd/livepeer/starter/starter.go 7.68738% <0.00000%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@ad-astra-video ad-astra-video left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Built locally to test with no issues.

@rickstaa
Copy link
Member Author

Thanks!

@rickstaa rickstaa merged commit 5738a52 into master Nov 14, 2024
18 of 19 checks passed
@rickstaa rickstaa deleted the allow_float_price_per_unit branch November 14, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants